Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil panic on lifecycle OnStart/OnStop #917

Merged
merged 1 commit into from Aug 8, 2022
Merged

Fix nil panic on lifecycle OnStart/OnStop #917

merged 1 commit into from Aug 8, 2022

Commits on Aug 8, 2022

  1. Fix nil panic on lifecycle OnStart/OnStop 

    If fx lifecycle OnStart/OnStop is called with a nil context, we
panic.

Added tests that test this.

Also tagging another release with this fix.
    @sywhang
    sywhang committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    0792c04 View commit details
    Browse the repository at this point in the history