Ensure args match verbs in ConsoleLogger #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the format call for `Supplied` event. Previously, `\n%!(EXTRA string=)` was appended to `SUPPLY` logs when `ModuleName` was empty. Add tests to ensure format string contains the same number of verbs as there are arguments when logging an `Event` using `ConsoleLogger` for all relevant event types, Module info was added to fxevent in uber-go#863.
Codecov Report
@@ Coverage Diff @@
## master #877 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 30 30
Lines 1157 1157
=======================================
Hits 1140 1140
Misses 11 11
Partials 6 6
Continue to review full report at Codecov.
|
|
Example of the previous malformed log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the format call for
Suppliedevent.Previously,
\n%!(EXTRA string=)was appended toSUPPLYlogs whenModuleNamewas empty.Add tests to ensure format string contains the same number of verbs as
there are arguments when logging an
EventusingConsoleLoggerforall relevant event types,
Module info was added to fxevent in #863.