Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify non compliant decoration test #851

Merged
merged 2 commits into from Feb 25, 2022
Merged

Modify non compliant decoration test #851

merged 2 commits into from Feb 25, 2022

Commits on Feb 25, 2022

  1. Modify a non-compliant transitive decoration case 

    This removes a test that was added in a previous commit which highlights
a problematic transitive decoration of a parent-module provided-type.

Specifically, consider the following case.

Parent Module provides type A, and type B which depends on type A.
Child Module decorates type A and invokes something that depends on type B.

In such case, the invoked function in child Module should not see a version of
type B created with a decorated type A.

This is because the constructor for the type B lives outside the scope of the
decoration. The decoration can only affect child Scope's providers, and should
not affect parent-provided constructor directly.

This test case is not compliant with such case, so it should be modified.
    @sywhang
    sywhang committed Feb 25, 2022
    Copy the full SHA
    09eb91e View commit details
    Browse the repository at this point in the history

  2. Modify ineffective transitive decoration test case

    @sywhang
    sywhang committed Feb 25, 2022
    Copy the full SHA
    73a4997 View commit details
    Browse the repository at this point in the history