Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fxevent.Decorated and emit it from fx.Decorate #843

Merged
merged 3 commits into from Feb 19, 2022

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Feb 17, 2022

This adds Decorated event to fx/fxevent package. Similar to Provided, this emits information on the following:

  • The name of the decorator
  • The dependencies of the decorator
  • Types being decorated by the decorator

fx.Decorate now emits this event upon decoration.

This also needs to fix Dig to the latest master to include the dig.FillDecorateInfo API.

Ref: GO-1208

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #843 (695650f) into master (66a9373) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
+ Coverage   98.42%   98.45%   +0.03%     
==========================================
  Files          30       30              
  Lines        1076     1098      +22     
==========================================
+ Hits         1059     1081      +22     
  Misses         11       11              
  Partials        6        6              
Impacted Files Coverage Δ
fxevent/console.go 100.00% <100.00%> (ø)
fxevent/event.go 100.00% <100.00%> (ø)
fxevent/zap.go 100.00% <100.00%> (ø)
module.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a9373...695650f. Read the comment docs.

@sywhang sywhang merged commit b3efe53 into uber-go:master Feb 19, 2022
@sywhang sywhang deleted the decorate-log branch February 19, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants