Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call signal.Stop when signalReceivers is stopped #1198

Merged
merged 3 commits into from
May 15, 2024

Conversation

MarcoPolo
Copy link
Contributor

fixes #1197

@CLAassistant
Copy link

CLAassistant commented May 8, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.46%. Comparing base (696ed9a) to head (0cc6047).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1198      +/-   ##
==========================================
- Coverage   98.49%   98.46%   -0.04%     
==========================================
  Files          34       34              
  Lines        2858     2665     -193     
==========================================
- Hits         2815     2624     -191     
+ Misses         36       34       -2     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JacobOaks JacobOaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think this makes sense to me. Just one small question.

signal_test.go Outdated Show resolved Hide resolved
@JacobOaks JacobOaks merged commit cb9cccf into uber-go:master May 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

signalReceivers should call Signal.Stop(recv.signals) when stopped
3 participants