Private Modules #1030
Closed
Private Modules #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users have been requesting that our private provides functionality provided by uber-go#995 be extended by allowing a way to privatize an entire module. This change modifies fx.Private to implement fx.Option, allowing it to be passed to fx.App and fx.Module. When passed into a module, the entire module will be marked as private, meaning all provides and supplies of that module and its inner modules will be marked as private. ```go fx.New( fx.Module("SubModule", fx.Private, fx.Supply(5), fx.Provide(func() string { return "b"}), fx.Invoke(a int, b str) {}, // Runs w/ a = 5, b = "b" ), fx.Invoke(func(a int) {}), // This will fail fx.Invoke(func(b str) {}), // This will also fail ) ``` I opted for this API to stay consistent with the style of API we already allow for passing Private to Provide directly. This change also extracts all private-related definitions and testing out into separate files, `private.go` and `private_test.go`.
Codecov Report
@@ Coverage Diff @@
## master #1030 +/- ##
==========================================
- Coverage 98.04% 97.86% -0.19%
==========================================
Files 39 40 +1
Lines 1994 2010 +16
==========================================
+ Hits 1955 1967 +12
- Misses 31 34 +3
- Partials 8 9 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Closing for now, missed a couple key things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users have been requesting that our private provides functionality provided by #995 be extended by allowing a way to privatize an entire module (Ref: #1020).
This change modifies fx.Private to implement fx.Option, allowing it to be passed to fx.App and fx.Module.
When passed into a module, the entire module will be marked as private, meaning all provides and supplies of that module and its inner modules will be marked as private.
I opted for this API to stay consistent with the style of API we already allow for passing Private to Provide directly.
This change also extracts all private-related definitions and testing out into separate files,
private.goandprivate_test.go.