Fix nil panic on lifecycle OnStart/OnStop #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If fx lifecycle OnStart/OnStop is called with a nil context, we panic. Added tests that test this. Also tagging another release with this fix.
abhinav
approved these changes
Aug 8, 2022
Codecov Report
@@ Coverage Diff @@
## master #917 +/- ##
=======================================
Coverage 98.71% 98.72%
=======================================
Files 30 30
Lines 1328 1332 +4
=======================================
+ Hits 1311 1315 +4
Misses 11 11
Partials 6 6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
sywhang
added a commit
to sywhang/fx
that referenced
this pull request
Oct 11, 2022
If fx lifecycle OnStart/OnStop is called with a nil context, we panic. Added tests that test this. Also tagging another release with this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If fx lifecycle OnStart/OnStop is called with a nil context, we
panic.
Added tests that test this.
Also tagging another release with this fix.