New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated version number for new tagged release #148
Conversation
Looks fine, however build is failing due to rubocop jumping a version. So can either, lock rubocop to a certain version or fix the error. Error is a bit confusing but from looking at rubocop issues, rubocop/rubocop#5953 and rubocop/rubocop#6032, you should be able to simply just move the https://github.com/ualbertalib/pushmi_pullyu/blob/master/lib/pushmi_pullyu/aip.rb Change: module PushmiPullyu::AIP
def create(noid)
# Stuff goes here
end
module_function :create
end To this: module PushmiPullyu::AIP
module_function
def create(noid)
# Stuff goes here
end
end If not, then just inline a disable rubocop on the offending line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib/pushmi_pullyu/aip.rb
Outdated
@@ -18,5 +18,6 @@ def create(noid) | |||
FileUtils.rm_rf(aip_directory) if File.exist?(aip_directory) | |||
end | |||
|
|||
# rubocop:disable Style/AccessModifierDeclarations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint/MissingCopEnableDirective: Re-enable Style/AccessModifierDeclarations cop with # rubocop:enable after disabling it.
Lint/UnneededCopDisableDirective: Unnecessary disabling of Style/AccessModifierDeclarations (unknown cop).
yep. it worked. thanks for pointing it out. it needs a reapprove now @murny |
Overlooked the version change when first tagging the release.
Updated the version number. Will tag a new release 1.0.1 with this change.