Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated version number for new tagged release #148

Merged
merged 7 commits into from Jul 25, 2018
Merged

Conversation

weiweishi
Copy link
Contributor

Overlooked the version change when first tagging the release.
Updated the version number. Will tag a new release 1.0.1 with this change.

@weiweishi weiweishi requested a review from murny July 25, 2018 18:14
@weiweishi weiweishi added this to In progress in Dev Team Kanban via automation Jul 25, 2018
@weiweishi weiweishi moved this from In progress to Needs review in Dev Team Kanban Jul 25, 2018
@murny
Copy link
Collaborator

murny commented Jul 25, 2018

Looks fine, however build is failing due to rubocop jumping a version.

So can either, lock rubocop to a certain version or fix the error. Error is a bit confusing but from looking at rubocop issues, rubocop/rubocop#5953 and rubocop/rubocop#6032, you should be able to simply just move the module_function line of code before the create method, so it acts similarilary to a private/protected method.

https://github.com/ualbertalib/pushmi_pullyu/blob/master/lib/pushmi_pullyu/aip.rb

Change:

module PushmiPullyu::AIP
  def create(noid)
    # Stuff goes here
  end

  module_function :create
end

To this:

module PushmiPullyu::AIP
  module_function

  def create(noid)
    # Stuff goes here
  end
end

If not, then just inline a disable rubocop on the offending line
# rubocop:disable Style/AccessModifierDeclarations

murny
murny previously approved these changes Jul 25, 2018
Copy link
Collaborator

@murny murny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment on fixing broken build.

Otherwise LGTM 👍

gif

@@ -18,5 +18,6 @@ def create(noid)
FileUtils.rm_rf(aip_directory) if File.exist?(aip_directory)
end

# rubocop:disable Style/AccessModifierDeclarations

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint/MissingCopEnableDirective: Re-enable Style/AccessModifierDeclarations cop with # rubocop:enable after disabling it.
Lint/UnneededCopDisableDirective: Unnecessary disabling of Style/AccessModifierDeclarations (unknown cop).

@weiweishi
Copy link
Contributor Author

yep. it worked. thanks for pointing it out. it needs a reapprove now @murny

@weiweishi
Copy link
Contributor Author

image

@weiweishi weiweishi merged commit e298ac5 into master Jul 25, 2018
Dev Team Kanban automation moved this from Needs review to Done Jul 25, 2018
@murny murny deleted the 1.0.1_version_update branch July 25, 2018 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants