Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies for Node v12 #38

Merged
merged 2 commits into from Jun 2, 2019
Merged

Upgrade dependencies for Node v12 #38

merged 2 commits into from Jun 2, 2019

Conversation

karlhorky
Copy link
Contributor

Thanks for this project! Really helpful to have more educational material in the community!

This PR upgrades fsevents to 1.2.9 to support Node v12 as documented in fsevents/fsevents#274.

It requires a major upgrade (2 -> 3) of react-scripts too due to the locked version number in their dependency. The list of breaking changes seemed to be short and the application works after the upgrade.

@tyroprogrammer
Copy link
Owner

@karlhorky - Thanks for the PR.

@tyroprogrammer tyroprogrammer merged commit 5c60d9d into tyroprogrammer:master Jun 2, 2019
@karlhorky karlhorky deleted the fix-dependencies branch June 3, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants