Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace execa with git bash #219

Closed
wants to merge 1 commit into from
Closed

Replace execa with git bash #219

wants to merge 1 commit into from

Conversation

gucong3000
Copy link

  • Run commands using Git bash as shell (for Windows)
  • Run commands using posix shelll (for other OS)
  • Remove execa from deps and enhance Cross-platform features

@gucong3000
Copy link
Author

Is there anything I can do for help this PR ?

@deecewan
Copy link

deecewan commented Feb 9, 2018

i'm not sure why you can't do this with execa?

@gucong3000
Copy link
Author

gucong3000 commented Feb 9, 2018 •
edited

i'm not sure why you can't do this with execa?

execa not support bash script like:

eslint $(git ls-files | grep \.js$)

@gucong3000 gucong3000 force-pushed the cross-platform-shell branch 3 times, most recently from ccb5f2e to 4cc8613 Compare May 16, 2018 06:19
@gucong3000
Copy link
Author

@deecewan
Hi, I reduced the dependency project

@typicode typicode closed this Oct 1, 2018
@typicode typicode changed the base branch from dev to master October 1, 2018 13:23
@typicode typicode reopened this Oct 1, 2018
@typicode typicode mentioned this pull request Oct 12, 2019
Merged
@typicode
Copy link
Owner

Closing, see #590
Thanks a lot for the PR!

@typicode typicode closed this Oct 12, 2019
@typicode typicode mentioned this pull request Oct 12, 2019
Merged
@gone-skiing gone-skiing mentioned this pull request Jan 7, 2020
Merged
@alexkcollier alexkcollier mentioned this pull request Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gucong3000 @deecewan @typicode