Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email actions to Environments endpoint. #314

Merged
merged 9 commits into from Feb 8, 2023

Conversation

fiasco
Copy link
Contributor

@fiasco fiasco commented Jan 26, 2023

This change allows support for enable/disable actions for Platform Email on the Environments endpoint.

Copy link
Collaborator

@danepowell danepowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests on this project are super easy to run locally: composer test

tests/Endpoints/EnvironmentsTest.php Outdated Show resolved Hide resolved
tests/Endpoints/EnvironmentsTest.php Outdated Show resolved Hide resolved
fiasco and others added 2 commits January 29, 2023 09:52
Co-authored-by: Dane Powell <dane@danepowell.com>
Co-authored-by: Dane Powell <dane@danepowell.com>
Copy link
Collaborator

@danepowell danepowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've still got failing tests. Let me know if you're having problems running them locally.

@fiasco
Copy link
Contributor Author

fiasco commented Feb 3, 2023

I tried out github's IDE but it doesn't provide an executable environment...

@danepowell
Copy link
Collaborator

I tried out github's IDE but it doesn't provide an executable environment...

That doesn't sound right. I just created a codespace, immediately saw a terminal window and typed composer install && composer test, everything worked great. Well, except for the failing tests :)

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b23ee41) compared to base (56d86a8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      codecov/codecov-action#314   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       255       257    +2     
===========================================
  Files             88        88           
  Lines           1676      1690   +14     
===========================================
+ Hits            1676      1690   +14     
Impacted Files Coverage Δ
src/Endpoints/Environments.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danepowell
Copy link
Collaborator

Sorry, looks like you got bit by codecov/codecov-action#317. I updated your PR so tests will at least run and pass, but we'll need for codecov/codecov-action#317 to be merged first.

@danepowell
Copy link
Collaborator

I have no clue why mutation tests are failing now. Some wires have really gotten crossed somewhere because they claim composer.lock still has a reference to phpunit 9.6.3, which it certainly does not. Possibly because you are using master instead of a feature branch? 😕

@danepowell
Copy link
Collaborator

Sorry, now blocked on codecov/feedback#126

@danepowell danepowell merged commit d313c41 into typhonius:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants