Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle annotations in TypeFromExpressionVisitor; fixes #5435 #5442

Merged
merged 4 commits into from Dec 14, 2022

Conversation

mernst
Copy link
Member

@mernst mernst commented Dec 12, 2022

Fixes #5435

smillst
smillst previously approved these changes Dec 12, 2022
@smillst smillst enabled auto-merge (squash) December 12, 2022 18:20
@mernst
Copy link
Member Author

mernst commented Dec 13, 2022

@smillst this is ready for re-review.
My main concern is that there are other corner cases that will come up in the future.

@smillst smillst merged commit 396a87b into typetools:master Dec 14, 2022
@smillst smillst deleted the issue5435 branch December 14, 2022 16:10
wmdietl pushed a commit to eisop/checker-framework that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with message TypeFromTree.defaultAction: conversion undefined for tree type ANNOTATION
2 participants