Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish records support #4871

Merged
merged 23 commits into from
Aug 20, 2021
Merged

Finish records support #4871

merged 23 commits into from
Aug 20, 2021

Commits on Aug 6, 2021

  1. Added a test for a method annotation on a canonical constructor.

    @neilccbrown
    neilccbrown committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    bec8b7f View commit details
    Browse the repository at this point in the history

  2. Made a new test run only on JDK 16 since it involves a record.

    @neilccbrown
    neilccbrown committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    a76bb18 View commit details
    Browse the repository at this point in the history

  3. Generalised the exception for formatting outside JDK 16 to include al… 

    …l directories ending in -records, thus encompassing the new lock-records directory.
    @neilccbrown
    neilccbrown committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    4a63b87 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2021

  1. Added a DisbarUseChecker that gives an error if you use a constructor… 

    …, method or field annotated as @DisbarUse, and a class which shows it works. This will be used for checking records.
    @neilccbrown
    neilccbrown committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    2b996a0 View commit details
    Browse the repository at this point in the history

  2. Added support for @DisbarUse on parameters.

    @neilccbrown
    neilccbrown committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    cc38be0 View commit details
    Browse the repository at this point in the history

  3. Added a test showing that javac transfer of annotations in records is… 

    … working properly.
    @neilccbrown
    neilccbrown committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    53d6e64 View commit details
    Browse the repository at this point in the history

  4. Added a test which shows that annotations on record components in stu… 

    …bs are not currently transferred to methods, fields and constructor parameters.
    @neilccbrown
    neilccbrown committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    e004858 View commit details
    Browse the repository at this point in the history

  5. Corrected DisbarUseVisitor to use the type factory methods for fetchi… 

    …ng annotations, rather than fetching them directly.
    @neilccbrown
    neilccbrown committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    5a08f28 View commit details
    Browse the repository at this point in the history

  6. Corrected some comments and a method name in some existing code.

    @neilccbrown
    neilccbrown committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    3c6f545 View commit details
    Browse the repository at this point in the history

  7. Added a further test to check for annotations not being copied to par… 

    …ameters of canonical but non-compact constructors.
    @neilccbrown
    neilccbrown committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    3a7fe94 View commit details
    Browse the repository at this point in the history

  8. Fixed stub parsing to transfer appropriate annotations on record comp… 

    …onents across to the corresponding field, method and compact canonical constructor parameter.
    @neilccbrown
    neilccbrown committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    3b06fe5 View commit details
    Browse the repository at this point in the history

  9. Added missing Javadoc @param.

    @neilccbrown
    neilccbrown committed Aug 8, 2021
    Configuration menu
    Copy the full SHA
    7712609 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Merge ../checker-framework-branch-master into records-finish

    @mernst
    mernst committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    5461f12 View commit details
    Browse the repository at this point in the history

  2. Fix cut-and-paste error

    @mernst
    mernst committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    b65b6aa View commit details
    Browse the repository at this point in the history

  3. Add comment

    @mernst
    mernst committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    b62b06f View commit details
    Browse the repository at this point in the history

  4. Document @DisbarUse

    @mernst
    mernst committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    f77a093 View commit details
    Browse the repository at this point in the history

  5. Move initializer

    @mernst
    mernst committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    937711d View commit details
    Browse the repository at this point in the history

  6. Fill comment

    @mernst
    mernst committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    b76effd View commit details
    Browse the repository at this point in the history

  7. Tweak comments

    @mernst
    mernst committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    04e1aff View commit details
    Browse the repository at this point in the history

  8. Merge ../checker-framework-branch-master into records-finish

    @mernst
    mernst committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    2e65063 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2021

  1. Refactored method as suggested in code review.

    @neilccbrown
    neilccbrown committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    c6f9cca View commit details
    Browse the repository at this point in the history

  2. Added a clarifying comment and made some code clearer.

    @neilccbrown
    neilccbrown committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    792b694 View commit details
    Browse the repository at this point in the history

  3. Changed the type of set to one with deterministic navigation.

    @neilccbrown
    neilccbrown committed Aug 13, 2021
    Configuration menu
    Copy the full SHA
    41c5dc7 View commit details
    Browse the repository at this point in the history