Fix handling of exception edges in backward analysis #4863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msridhar
commented
Aug 4, 2021
| a [ LocalVariable ] | ||
| ~~~~~~~~~ | ||
| TransferInput#21 | ||
| After: live variables = a, b |
There was a problem hiding this comment.
Before the logic change in BackwardAnalysisImpl, the live variable set here would incorrectly be missing b
msridhar
changed the title
|
This looks reasonable to me, but I'm not the right person to review it, nor am I sure who is. @mernst, can you either review this change yourself or assign someone else who you think is an appropriate reviewer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4861