Allow for multiple method parameters to be @MustCallAlias in Resource Leak Checker; fixes #4785 #4808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mernst
changed the title
msridhar
requested changes
Jul 20, 2021
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Outdated
Show resolved
Hide resolved
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Outdated
Show resolved
Hide resolved
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Outdated
Show resolved
Hide resolved
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Outdated
Show resolved
Hide resolved
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Show resolved
Hide resolved
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Outdated
Show resolved
Hide resolved
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Outdated
Show resolved
Hide resolved
msridhar
requested changes
Jul 27, 2021
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Show resolved
Hide resolved
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Outdated
Show resolved
Hide resolved
…e nor a LocalVariableNode
msridhar
requested changes
Jul 27, 2021
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Outdated
Show resolved
Hide resolved
msridhar
reviewed
Jul 27, 2021
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Outdated
Show resolved
Hide resolved
msridhar
requested changes
Jul 27, 2021
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Show resolved
Hide resolved
msridhar
approved these changes
Jul 27, 2021
kelloggm
requested changes
Jul 28, 2021
| .allMatch( | ||
| mustCallAliasArgument -> | ||
| mustCallAliasArgument instanceof FieldAccessNode | ||
| || mustCallAliasArgument instanceof ThisNode); |
There was a problem hiding this comment.
In the Checker Framework, the preferred style is to use a loop rather than a stream. Can you rewrite this to use a loop rather than a stream?
msridhar
reviewed
Jul 28, 2021
checker/tests/resourceleak/MultipleMethodParamsMustCallAliasTest.java
Outdated
Show resolved
Hide resolved
|
@kelloggm do you have any further comments on this one? |
kelloggm
approved these changes
Jul 29, 2021
wmdietl
pushed a commit
to eisop/checker-framework
that referenced
this pull request
Aug 3, 2021
… Leak Checker; fixes typetools#4785 (typetools#4808)
wmdietl
pushed a commit
to eisop/checker-framework
that referenced
this pull request
Aug 3, 2021
… Leak Checker; fixes typetools#4785 (typetools#4808)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4785.
In this PR, methods and constructors are allowed to have Multiple @MustCallAlias arguments like:
public @MustCallAlias SequenceInputStream(@MustCallAlias InputStream s1, @MustCallAlias InputStream s2) {...}If a call has @MustCallAlias annotation, then for each argument passed in the @MustCallAlias position, it creates a set containing the argument and it's resource aliases and add it to the set of obligations. Consider the following example:
SequenceInputStream s3 = new SequenceInputStream(s1, s2)It creates two sets {s1, s3} and {s2, s3}, and then adds them to the set of obligations.