Correct implementation of IdentityMostlySingleton. #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mernst
approved these changes
Aug 3, 2020
wmdietl
added a commit
to wmdietl/checker-framework
that referenced
this pull request
Aug 4, 2020
|
This is a cool find! I wonder whether we could extend the Interning Checker to allow us to prevent this bug... I've created #3558 with an alternative, that might be a tad more efficient and I find it a bit clearer what the actual problem is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change on
t-rasmud/repro-casting-issuebranch makes the test case in for #3484 pass. I was also reproduce the issue using an existing test checker.Fixes #3484.