New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baseline support for records #3017
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9449ea4
Add baseline support for records
michaelhixson b5d9b46
Revert changes outside of javacutil and dataflow
michaelhixson 4c1ba95
Restore TYPE_ANNOTATION case, which was accidentally removed
michaelhixson 5d5ae40
Revert accidental changes
michaelhixson 44679dd
Revert accidental changes
michaelhixson d7403cf
Try fixing code style issues
michaelhixson 7f4b4ca
Add documentation
mernst d0e1808
Merge ../checker-framework-branch-master into support-records
mernst 469e846
Reuse utility methods
michaelhixson dcd4c4c
Use a utility method
michaelhixson 85b30f1
Fix AnnotationUtils.getElementKindsForElementType
michaelhixson a41a532
Dynamically detect class tree kinds, avoid hardcoded enum set
michaelhixson bfb4b42
See if this is what the code formatter is complaining about
michaelhixson bc8371b
Add javadocs
michaelhixson 1aa4234
Move field initialization together.
wmdietl 8433f13
Review feedback: Remove unwanted comment
michaelhixson bfe2367
Review feedback: Remove useless assertion
michaelhixson 980870b
Add classElementKinds and isClassElement to ElementUtils
michaelhixson 94916c7
Use new ElementUtils methods
michaelhixson File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding your second question: 3ef0af3 added this work-around.
I'm not quite sure why we need it, as we use at least a Java 9 compiler, so using MODULE should always work.
I agree that using
ElementKind.valueOf("MODULE")
should also work here.Could you try that as a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for filing #3019.