Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve exception handling in
CalledMethodsTransfer.accumulate
(#6233)
- Loading branch information
Showing
2 changed files
with
41 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import java.io.IOException; | ||
import org.checkerframework.checker.calledmethods.qual.*; | ||
|
||
class ExceptionalPath2 { | ||
|
||
interface Resource { | ||
void a(); | ||
|
||
void b() throws IOException; | ||
} | ||
|
||
Resource r; | ||
|
||
// Regression test for an obscure bug: in some cases, the called | ||
// methods transfer function would silently fail to update the | ||
// set of known called methods along exceptional paths. That | ||
// would a spurious precondition error on this method. | ||
@EnsuresCalledMethods( | ||
value = "this.r", | ||
methods = {"b"}) | ||
void test() { | ||
try { | ||
try { | ||
r.a(); | ||
} finally { | ||
r.b(); | ||
} | ||
} catch (IOException ignored) { | ||
// The only way to get here is if `r.b()` started running and | ||
// threw an IOException. We no longer know whether `r.a()` | ||
// has been called, since `r.b()` might have overwritten `r` | ||
// before throwing. | ||
// ::error: (assignment) | ||
@CalledMethods({"a"}) Resource x = r; | ||
} | ||
} | ||
} |