Patch IsNumber decorator with maxDecimalPlaces option set for numbers in scientific annotation #2166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The IsNumber() decorator doesn't work on scientifically annotated numbers when specifying
maxDecimalPlaces
option becausevalue.toString()
has no dot in it and crashes (see issue: #1705).class-validator/src/decorator/typechecker/IsNumber.ts
Line 34 in 4a0ec66
This patch reworks the whole handling of
maxDecimalPlaces
option in order to make it work with scientific numbers.The logic behind the patch is
toFixed(maxDecimalPlaces)
the input so it is represented as a string with a maximum number of decimals as specified by the optionmaxDecimalPlaces
, thenparseFloat()
it to be compared with the original input.If there is a difference with the original input, it means it has a number of decimals >
maxDecimalPlaces
because they have been truncated bytoFixed(maxDecimalPlaces)
Checklist
Update index.md
)develop
)npm run prettier:check
passesnpm run lint:check
passesFixes
fixes #1705