feat: Added a ISO639-1 decorator #2047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decorator is used to check if a string matches the ISO 639-1, that describes how country languages prefixes should look like. Fortunatelly, it just delegates the validation to an already existent function in the validator library
|
It would be great if you could update the README.md as well! |
rubiin
reviewed
May 28, 2023
robinvw1
reviewed
Dec 20, 2023
| } | ||
|
|
||
| /** | ||
| * Checks if the string is an ISIN (stock/security identifier). |
There was a problem hiding this comment.
Copy/paste error from other decorator.
|
@Gustrb Any update on your PR? This looks like a nice addition 😊 |
|
@te-online, I kind of forgot about it. Will work on adding some tests and fixing the comments pointed out :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decorator is used to check if a string matches the ISO 639-1, that describes how country languages prefixes should look like.
Fortunatelly, it just delegates the validation to an already existent function in the validator library
This PR implements issue #2045