Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle symbols in constraintToString method with array #2027

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

adrienboulle
Copy link
Contributor

Description

When implementing custom validators and using array of symbols as constraints, an error is raised when the error message is generated for a failed validation.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #2026

@adrienboulle
Copy link
Contributor Author

@NoNameProvided would you mind having a look at this PR?

@adrienboulle
Copy link
Contributor Author

@braaar would you mind having a look at this PR?

@adrienboulle
Copy link
Contributor Author

hi @braaar I'm having trouble having this PR reviews, let me know if I'm doing anything wrong I would be more than happy to fix it :)

thx a lot!

@adrienboulle
Copy link
Contributor Author

hi @braaar could you review this quick PR ?
It's just a following PR regarding this one: #1794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix: handle symbols in constraintToString method with array
1 participant