fix: set forbidUnknownValues to true by default
#1403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeguta
changed the title
…idator into fix-438-forbid-unknown-values
NoNameProvided
force-pushed
the
develop
branch
from
acb7de1
to
c6984bb
Compare
palharez
approved these changes
Dec 23, 2021
aarifkhamdi
approved these changes
Feb 16, 2022
braaar
reviewed
Oct 3, 2022
| `No metadata found. There is more than once class-validator version installed probably. You need to flatten your dependencies.` | ||
| `No metadata found. There is more than one class-validator version installed probably. You need to flatten your dependencies.` |
There was a problem hiding this comment.
This change seems to no belong in this PR, and there is another PR for this already #1127
|
Is this going to be merged anytime soon? |
NoNameProvided
changed the title
forbidUnknownValues to true by default
|
This PR contains various unrelated changes, but I think all of this is landed already. The significant change of setting The changed tests seem fine for me on |
NoNameProvided
added
the
status: superset by another
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an attempted fix for #438
It does so with a breaking change that uses a safe default of
trueforforbidUnknownValues. Only an explicitfalsevalue would preserve the previous default behaviour.Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpassesFixes
fixes #438
Other
35f8d20 Moved
@types/validatortodevDependencies1b6af93 Fixed a couple of tests that were not returning promises and failing silently