Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boolean conversion from string values when enableImplicitConversion option is set to true #1329

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

mubin-ct
Copy link

@mubin-ct mubin-ct commented Sep 4, 2022

Description

This PR will extend the functionality to convert the boolean values even if provided as strings.
Flow before this PR:
canAccess: 'false' yields canAccess: true

Flow after this PR:
canAccess: 'false' will yield to canAccess: false

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #1328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

feat: support automatic casting of the string representation of a boolean value
2 participants