Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: minor update correcting a var name: users->user #1282

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

doc: minor update correcting a var name: users->user #1282

wants to merge 1 commit into from

Conversation

gdarquie
Copy link

@gdarquie gdarquie commented Jul 18, 2022 •
edited

Description

If I am not wrong, we talk about only one user here. The name of the variable "users" is misleading, shouldn't it be "user"?

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #[issue number], fixes #[issue number]

@gdarquie gdarquie changed the title Update README.md Readme : minor update Jul 18, 2022
@gdarquie gdarquie changed the title Readme : minor update Readme: minor update Jul 18, 2022
@gdarquie gdarquie changed the title Readme: minor update doc: minor update for readme (easy to check) Jul 18, 2022
@gdarquie gdarquie changed the title doc: minor update for readme (easy to check) doc: minor update for readme (easy to check^^) Jul 18, 2022
@gdarquie gdarquie changed the title doc: minor update for readme (easy to check^^) doc: minor update correcting a var name: users->user (easy to check^^) Jul 19, 2022
@gdarquie @saulotoledo
Update README.md
e66cb3a 
If I am not wrong, we talk about one only user here.
@saulotoledo saulotoledo changed the title doc: minor update correcting a var name: users->user (easy to check^^) doc: minor update correcting a var name: users->user Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gdarquie