Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lookup up property descriptors on the prototype #1258

Merged
merged 7 commits into from May 22, 2024

Conversation

CodyTseng
Copy link
Contributor

@CodyTseng CodyTseng commented Jul 1, 2022

Description

Object.getOwnPropertyDescriptor can't get the descriptor of the parent class property. Need to look up the property descriptor along the prototype chain.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

references #1257

@NoNameProvided NoNameProvided changed the title fix: looking up the property descriptor along the prototype chain fix: lookup up property descriptors on the prototype May 22, 2024
@NoNameProvided NoNameProvided merged commit a073b5e into typestack:develop May 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants