fix(eslint-plugin): [unbound-method] report on destructuring in function parameters

[auvred]

PR Checklist

• Addresses an existing open issue: fixes Bug: [unbound-method] Does not fail for destructured parameters #8947
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Old approach: query for VariableDeclarator, AssignmentExpression and check if they have ObjectPattern

New approach: query for ObjectPattern, check if VariableDeclarator, AssignmentExpression, AssignmentPattern its parent

---

We're iterating over ObjectPattern's properties:

1. If ObjectPatterns's parent has init node, check if it's safe to destructure this init node:
   • if it's unsafe, then report on this property and go to the next property
   • if it's safe, then check if ObjectPatterns's parent is AssignmentPattern:
     • if false, go to the next property
     • if true, continue working on this property
2. If ObjectPattern has a type annotation, then check if it's safe to destructure this type
3. If there is no type annotation, check the inferred property type

[typescript-eslint]

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	7dafb3a
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66352c91184fe100088c2860
😎 Deploy Preview	https://deploy-preview-8952--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🔴 down 5 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7dafb3a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin --coverage=false
• nx test eslint-plugin
• nx test scope-manager --coverage=false
• nx test typescript-estree --coverage=false
• nx run types:build
• nx test visitor-keys --coverage=false
• nx test typescript-eslint --coverage=false
• nx test type-utils --coverage=false
• nx test repo-tools --coverage=false
• nx run repo-tools:postinstall-script
• nx test utils --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test parser --coverage=false
• nx test ast-spec --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test type-utils
• nx test eslint-plugin-internal
• nx test typescript-eslint
• nx test scope-manager
• nx test parser
• nx test typescript-estree
• nx test utils
• nx test visitor-keys
• nx test rule-schema-to-typescript-types
• nx test repo-tools
• nx run-many --target=typecheck --parallel
• nx test ast-spec
• nx run integration-tests:test
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[kirkwaiblinger]

I really like these changes! The algorithm change makes sense to me, the code is easy to follow, and the new code for type inspection is very thorough.

Added a few questions and some test cases to flesh out edge cases.

[kirkwaiblinger]

should there be some kind of assertion here to ensure that every way that ObjectPattern could occur is handled (especially in light of the bug that this PR fixes)? Relates to #6225

[auvred]

const { log } = console;

In our current configuration, the console.log declarations are under @types/node. So if we remove this check, the rule will report on this case. Not sure what's the best solution there..