fix(eslint-plugin): [no-unnecessary-type-assertion] declares are always defined, so always check declares

[abrahamguo]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-unnecessary-type-assertion] Does not flag on unnecessary nonnull assertion on declared value #8794
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

When checking unnecessary non-null assertions, always check declares because they cannot be "not defined yet".

[typescript-eslint]

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	7f4b1f0
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6638cc19c2616000089915cb
😎 Deploy Preview	https://deploy-preview-8901--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7f4b1f0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin --coverage=false
• nx test eslint-plugin
• nx test typescript-eslint --coverage=false
• nx test utils --coverage=false
• nx test visitor-keys --coverage=false
• nx run types:build
• nx test typescript-estree --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx run repo-tools:postinstall-script
• nx test repo-tools --coverage=false
• nx test scope-manager --coverage=false
• nx test type-utils --coverage=false
• nx test ast-spec --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test eslint-plugin-internal --coverage=false
• nx test parser --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test type-utils
• nx test typescript-eslint
• nx test scope-manager
• nx test visitor-keys
• nx test ast-spec
• nx test utils
• nx test parser
• nx test typescript-estree
• nx test eslint-plugin-internal
• nx test rule-schema-to-typescript-types
• nx test repo-tools
• nx run-many --target=typecheck --parallel
• nx run integration-tests:test
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.