Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [prefer-readonly] refine report locations #8894

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Apr 10, 2024

Blocked by #8869 since they'll use a shared utility

PR Checklist

Overview

class Clazz {
  // before
  private shouldBeReadonly = () => { /* ... */ };
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  // after
  private shouldBeReadonly = () => { /* ... */ };
  ^^^^^^^^^^^^^^^^^^^^^^^^
}

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b5cad08
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/661640471668c400080703a7
😎 Deploy Preview https://deploy-preview-8894--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

* out in front of the key, and the key itself, but not anything afterwards,
* i.e. parens, type annotations, method bodies, or `?`.
*/
function getReportLoc(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extract and reuse utilities from #8869

@kirkwaiblinger kirkwaiblinger changed the title [prefer-readonly] Refine report locations fix(eslint-plugin): [prefer-readonly] Refine report locations Apr 10, 2024
@kirkwaiblinger kirkwaiblinger changed the title fix(eslint-plugin): [prefer-readonly] Refine report locations fix(eslint-plugin): [prefer-readonly] refine report locations Apr 10, 2024
@kirkwaiblinger kirkwaiblinger added blocked by another PR PRs which are ready to go but waiting on another PR enhancement New feature or request labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by another PR PRs which are ready to go but waiting on another PR enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Improve lint error report location
1 participant