Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [init-declarations] refine report locations #8893

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

/* eslint @typescript-eslint/init-declarations: ["error", "always"] */
// before
let bar: number | undefined | string;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
// after
let bar: number | undefined | string;
    ^^^

Note that the following example is unchanged

/* eslint @typescript-eslint/init-declarations: ["error", "never"] */
let bar: number | undefined | string = 3;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b0b686d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/661642fb0a8af10008f3875b
😎 Deploy Preview https://deploy-preview-8893--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkwaiblinger kirkwaiblinger changed the title fix(eslint-plugin): [init-declarations] refine report loc fix(eslint-plugin): [init-declarations] refine report locations Apr 10, 2024
@kirkwaiblinger kirkwaiblinger force-pushed the init-declarations-refine-report-loc branch from 6b5d7c2 to 06bfce3 Compare April 10, 2024 07:25
@kirkwaiblinger kirkwaiblinger force-pushed the init-declarations-refine-report-loc branch from 06bfce3 to 7ff131d Compare April 10, 2024 07:26
@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review April 10, 2024 07:42
@kirkwaiblinger kirkwaiblinger added the enhancement New feature or request label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant