Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rule-tester): support multipass fixes #8883

Open
wants to merge 8 commits into
base: v8
Choose a base branch
from

Conversation

auvred
Copy link
Member

@auvred auvred commented Apr 8, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0a92776
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66336ce9b60d6c00080b9f1c
😎 Deploy Preview https://deploy-preview-8883--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@auvred auvred changed the base branch from main to v8 April 8, 2024 16:23
@auvred auvred changed the base branch from v8 to main April 8, 2024 16:24
@auvred auvred changed the base branch from main to v8 April 8, 2024 16:27
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks lovely to me - and great test cases too!

I think @bradzacher will want to take a look too if he has time, given that he wrote a bunch on the feature requests.

Big Boss from Metal Gear nodding goofily at a computer, then turning to the camera and giving a thumbs up

packages/rule-tester/src/RuleTester.ts Show resolved Hide resolved
packages/rule-tester/src/RuleTester.ts Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Apr 23, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion, looks great to me! 🔥

Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I LOVE this feature! ❤️

Approved pending resolution of comments, which may not require any changes at all. If you do make changes, I think they're simple enough that you have carte blanche from me to merge without an explicit reapproval from me.

auvred and others added 2 commits May 2, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rule-tester] support multipass fixes
3 participants