Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ast-spec type import snapshot errors #8699

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 17, 2024

PR Checklist

Overview

Runs yarn jest -u in packages/ast-spec.

Also updates all @babel/* packages to latest. Some may have fallen out of sync.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 147b022
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65f712e5db65210008bb8ec3
😎 Deploy Preview https://deploy-preview-8699--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (8400939) to head (147b022).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8699      +/-   ##
==========================================
+ Coverage   87.21%   88.10%   +0.89%     
==========================================
  Files         251      402     +151     
  Lines       12315    14029    +1714     
  Branches     3883     4117     +234     
==========================================
+ Hits        10740    12360    +1620     
- Misses       1305     1370      +65     
- Partials      270      299      +29     
Flag Coverage Δ
unittest 88.10% <ø> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 154 files with indirect coverage changes

@JoshuaKGoldberg
Copy link
Member Author

👋 FYI @typescript-eslint/triage-team I'm merging this as-is to unblock the main branch. Please yell at me if I'm making a big mistake!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 71bfb7c into typescript-eslint:main Mar 17, 2024
60 of 61 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the ast-spec-snapshot-fixes branch March 17, 2024 16:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: ast-spec snapshot failures on main
1 participant