Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tmp skip cache for eslint-plugin lint #8539

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Feb 23, 2024

  • Fixes an existing issue with stale rule configs
  • Updates duplicate CI job names
  • Disables the cache for linting eslint-plugin to see if the prettier sync flakiness goes away

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6eecaa5
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65d8ab38261a210008d8d0c1
😎 Deploy Preview https://deploy-preview-8539--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg
Copy link
Member

For tracking: #8373

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (fb82a33) to head (6eecaa5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8539      +/-   ##
==========================================
+ Coverage   86.92%   87.69%   +0.77%     
==========================================
  Files         251      397     +146     
  Lines       12250    13841    +1591     
  Branches     3864     4072     +208     
==========================================
+ Hits        10648    12138    +1490     
- Misses       1332     1403      +71     
- Partials      270      300      +30     
Flag Coverage Δ
unittest 87.69% <ø> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 149 files with indirect coverage changes

@JamesHenry JamesHenry marked this pull request as ready for review February 23, 2024 15:28
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@bradzacher bradzacher merged commit 025e892 into main Feb 25, 2024
63 checks passed
@bradzacher bradzacher deleted the skip-cache-eslint-plugin-lint branch February 25, 2024 11:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants