Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace extend any with unknown for no-unnecessary-type-constra… #6976

Conversation

takanome-dev
Copy link
Contributor

PR Checklist

Overview

This pr replaces the default constraint for no-unnecessary-type-constraint from any to unknown in the docs.

Note: I'm not really sure if I have to change all the any to unknown in the example block. I tried in the test file and they all failed 😓 I have added two more examples using unknown (only in the incorrect section).

Please do let me know if there are additional steps I need to take 🙏

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @takanome-dev!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Apr 30, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2042a9f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64738d7210e3760008b83234
😎 Deploy Preview https://deploy-preview-6976--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long @takanome-dev, I'd meant to enthusiastically respond but it slipped by. Thanks for sending!

Mostly looks great - just one suggestion for the docs to make the phrasing more clear. Thoughts?

Heidi Gardner dressed in fashion in SNL's Weekend Update enthusiastically saying 'I love it!'

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label May 28, 2023
takanome-dev and others added 2 commits May 28, 2023 17:18
…nt.md

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@takanome-dev
Copy link
Contributor Author

Mostly looks great - just one suggestion for the docs to make the phrasing more clear. Thoughts?

Sounds good 👍 Thanks for taking the time reviewing this 🙂

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lady in red dress emphatically gesturing and saying 'flawless'

@JoshuaKGoldberg JoshuaKGoldberg merged commit f5d174d into typescript-eslint:main May 31, 2023
38 of 40 checks passed
@takanome-dev takanome-dev deleted the no-unnecessary-type-constraint-extending-unknown branch May 31, 2023 10:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: no-unnecessary-type-constraint should mention extending unknown
2 participants