Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [promise-function-async] check for promises in implicit return types #6330

Merged
merged 2 commits into from Feb 20, 2023
Merged

feat(eslint-plugin): [promise-function-async] check for promises in implicit return types #6330

merged 2 commits into from Feb 20, 2023

Commits on Feb 10, 2023

  1. [promise-function-async] Only allow unions in explicit return types 

    When we return a union containing a promise from a function
implicitly, it's often a mistake. This commit makes it so if the
return type is explicit, any `Promise` in the return type (whether
it's part of a union or not) will flag the function. If it is
intentional, make the return type explicit.

Fixes typescript-eslint#6329
    @ericbf
    ericbf committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    ea34d23 View commit details
    Browse the repository at this point in the history

  2. Refrain from renaming the type-util, instead add an optional fourth p… 

    …aram.
    @ericbf
    ericbf committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    be9531d View commit details
    Browse the repository at this point in the history