Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow multiple rule names in pr titles #6148

Merged
merged 1 commit into from Dec 2, 2022

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

@JoshuaKGoldberg asked for this and I needed it for #6118
In general we want people to do separate PRs so that changes are smaller - but sometimes it really is necessary to do everything in one PR - so might as well allow our validator to validate

@nx-cloud
Copy link

nx-cloud bot commented Dec 2, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1b8c64a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 2, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1b8c64a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63895437fdb22d0007865158
😎 Deploy Preview https://deploy-preview-6148--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

@bradzacher bradzacher merged commit bed6356 into main Dec 2, 2022
@bradzacher bradzacher deleted the bradzacher-patch-2022-12-02 branch December 2, 2022 02:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants