Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scope-manager): add support for TS4.9 satisfies expression #6058

Closed
wants to merge 1 commit into from

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloud bot commented Nov 22, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 43f83dc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 22, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 43f83dc
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/637c55f86eb07600081a6ac5
😎 Deploy Preview https://deploy-preview-6058--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #6058 (43f83dc) into main (01159d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6058   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files         366      366           
  Lines       12352    12353    +1     
  Branches     3612     3612           
=======================================
+ Hits        11275    11276    +1     
  Misses        768      768           
  Partials      309      309           
Flag Coverage Δ
unittest 91.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/scope-manager/src/referencer/Referencer.ts 95.98% <100.00%> (+0.01%) ⬆️

@bradzacher bradzacher closed this Nov 22, 2022
@bradzacher
Copy link
Member Author

#6059 oops - was playing with some new tools and created a duplicate

@bradzacher bradzacher deleted the 6057-satisfies-scope-analysis branch November 22, 2022 06:26
@bradzacher bradzacher restored the 6057-satisfies-scope-analysis branch November 22, 2022 06:26
@bradzacher bradzacher deleted the 6057-satisfies-scope-analysis branch November 22, 2022 06:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [@typescript-eslint/no-unused-vars] not collect used types on satisfies operator
1 participant