Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [prefer-optional-chain] handle binary expressions in negated or #5992

Merged
merged 4 commits into from Nov 16, 2022
Merged

fix(eslint-plugin): [prefer-optional-chain] handle binary expressions in negated or #5992

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de139e8
fix/issue5991-fix-prefer-optional-chain-BinaryExpression-in-negated-or
omril1 Nov 15, 2022
126404b
Merge branch 'main' into fix/issue5991-fix-prefer-optional-chain-Bina…
omril1 Nov 15, 2022
a9f1a05
CR
omril1 Nov 15, 2022
22be168
Merge branch 'main' into fix/issue5991-fix-prefer-optional-chain-Bina…
omril1 Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/eslint-plugin/src/rules/prefer-optional-chain.ts
View file
Open in desktop
Expand Up @@ -407,6 +407,10 @@ export default util.createRule({
propertyText = getMemberExpressionText(node.property);
break;

case AST_NODE_TYPES.BinaryExpression:
propertyText = sourceCode.getText(node.property);
break;
JoshuaKGoldberg marked this conversation as resolved.
Show resolved Hide resolved

/* istanbul ignore next */
default:
throw new Error(
Expand Down
2 changes: 2 additions & 0 deletions packages/eslint-plugin/tests/rules/prefer-optional-chain.test.ts
View file
Open in desktop
Expand Up @@ -198,6 +198,8 @@ ruleTester.run('prefer-optional-chain', rule, {
'foo && foo[bar as string] && foo[bar as string].baz;',
'foo && foo[1 + 2] && foo[1 + 2].baz;',
'foo && foo[typeof bar] && foo[typeof bar].baz;',
'!foo[1 + 1] || !foo[1 + 2];',
'!foo[1 + 1] || !foo[1 + 1].foo;',
'!foo || !foo[bar as string] || !foo[bar as string].baz;',
'!foo || !foo[1 + 2] || !foo[1 + 2].baz;',
'!foo || !foo[typeof bar] || !foo[typeof bar].baz;',
Expand Down