Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [prefer-optional-chain] fixer produces wrong logic #5919

Merged
merged 10 commits into from Jan 26, 2023
Merged

fix(eslint-plugin): [prefer-optional-chain] fixer produces wrong logic #5919

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1bcc7f7
fix(eslint-plugin): [prefer-optional-chain] fixer produces wrong logi…
sviat9440 Nov 2, 2022
27a22ae
Update packages/eslint-plugin/src/rules/prefer-optional-chain.ts
JoshuaKGoldberg Nov 13, 2022
c0083b1
Merge branch 'main'
JoshuaKGoldberg Nov 13, 2022
ca2f338
Merge branch 'main' into fix/1438
sviat9440 Nov 15, 2022
787f938
fix(eslint-plugin): [prefer-optional-chain] fix tests
sviat9440 Nov 15, 2022
874c21a
fix(eslint-plugin): [prefer-optional-chain] fix tests
sviat9440 Nov 21, 2022
b965ba3
Merge branch 'master' into fix/1438
Nov 21, 2022
eab2a11
Merge branch 'main' into fix/1438
sviat9440 Nov 24, 2022
d9e4f18
Merge branch 'main' into fix/1438
sviat9440 Nov 27, 2022
47304f3
Merge branch 'main' into fix/1438
JoshuaKGoldberg Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 13 additions & 3 deletions packages/eslint-plugin/src/rules/prefer-optional-chain.ts
View file
Open in desktop
Expand Up @@ -478,10 +478,20 @@ function reportIfMoreThanOne({
shouldHandleChainedAnds &&
previous.right.type === AST_NODE_TYPES.BinaryExpression
) {
let operator = previous.right.operator;
if (
previous.right.operator === '!==' &&
// TODO(#4820): Use the type checker to know whether this is `null`
previous.right.right.type === AST_NODE_TYPES.Literal &&
previous.right.right.raw === 'null'
) {
// case like foo !== null && foo.bar !== null
operator = '!=';
}
// case like foo && foo.bar !== someValue
optionallyChainedCode += ` ${
previous.right.operator
} ${sourceCode.getText(previous.right.right)}`;
optionallyChainedCode += ` ${operator} ${sourceCode.getText(
previous.right.right,
)}`;
}

context.report({
Expand Down