tests: add dependency constraints to eslint-plugin tests

[bradzacher]

PR Checklist

• Addresses an existing open issue: ref Add automated regression testing against old TS versions #1752
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Doing this ahead of #5573 to improve reviewability.
This PR marks all of our dependency requirements for tests back to TSv4.0.8 - I didn't go back further because #5915 bumps the minimum past that anyways

[typescript-eslint]

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9396b38. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 46 targets

• Node 18 - nx test @typescript-eslint/eslint-plugin
• Node 14 - nx test @typescript-eslint/eslint-plugin --coverage=false
• nx run-many --target=typecheck --all --parallel
• Node 18 - nx test @typescript-eslint/visitor-keys
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/type-utils
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/eslint-plugin-tslint
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/scope-manager
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/typescript-estree
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/parser
• Node 14 - nx test @typescript-eslint/ast-spec --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/parser --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/eslint-plugin-tslint --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx test @typescript-eslint/ast-spec
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/type-utils --coverage=false
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/utils --coverage=false
• Node 18 - nx test @typescript-eslint/eslint-plugin-internal
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/visitor-keys --coverage=false
• Node 14 - nx test @typescript-eslint/typescript-estree --coverage=false
• Node 14 - nx test @typescript-eslint/eslint-plugin-internal --coverage=false
• nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx test @typescript-eslint/scope-manager --coverage=false
• Node 18 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 14 - nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website
• nx run-many --target=build --all --parallel --exclude website --exclude website

---

Sent with 💌 from NxCloud.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	9396b38
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63756ed625114a0009371037
😎 Deploy Preview	https://deploy-preview-5916--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[JoshuaKGoldberg]

🔥

[JoshuaKGoldberg]

I see some new test failures after my merge - will try to fix soon... ✅

(they were existing, somewhat)

[JoshuaKGoldberg]

non-nullable-type-assertion-style has a failure - otherwise this looks good to go!

[bradzacher]

Interestingly the changes to that failing test have exposed a bug in our underlying project caching logic!
Fix is in #5999

I merged #5999 into this PR, so we'll have to wait for that one to land first.

[codecov]

Codecov Report

Merging #5916 (9396b38) into main (530e0e6) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5916      +/-   ##
==========================================
- Coverage   91.42%   91.29%   -0.14%     
==========================================
  Files         365      365              
  Lines       12342    12343       +1     
  Branches     3610     3610              
==========================================
- Hits        11284    11268      -16     
- Misses        753      767      +14     
- Partials      305      308       +3     

Flag	Coverage Δ
unittest	91.29% <100.00%> (-0.14%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/utils/src/eslint-utils/rule-tester/RuleTester.ts	70.23% <100.00%> (-15.31%)	⬇️
.../eslint-utils/rule-tester/dependencyConstraints.ts	66.66% <0.00%> (-33.34%)	⬇️

[JoshuaKGoldberg]

🔥