Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [consistent-indexed-object-style] handle interface generic #5746

Merged
merged 3 commits into from Oct 5, 2022
Merged

fix(eslint-plugin): [consistent-indexed-object-style] handle interface generic #5746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b27f69
fix(eslint-plugin): [consistent-indexed-object-style] handle interfac…
yeonjuan Oct 4, 2022
a6a4381
fix lint error
yeonjuan Oct 4, 2022
3619c4a
Merge branch 'main' into fix/#5472
JoshuaKGoldberg Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/eslint-plugin/src/rules/consistent-indexed-object-style.ts
View file
Open in desktop
@@ -1,5 +1,5 @@
import type { TSESLint, TSESTree } from '@typescript-eslint/utils';
import { AST_NODE_TYPES } from '@typescript-eslint/utils';
import { AST_NODE_TYPES, ASTUtils } from '@typescript-eslint/utils';

import { createRule } from '../util';

Expand Down Expand Up @@ -67,7 +67,7 @@ export default createRule<Options, MessageIds>({

if (parentId) {
const scope = context.getScope();
const superVar = scope.set.get(parentId.name);
const superVar = ASTUtils.findVariable(scope, parentId.name);
if (superVar) {
const isCircular = superVar.references.some(
item =>
Expand Down
22 changes: 21 additions & 1 deletion packages/eslint-plugin/tests/rules/consistent-indexed-object-style.test.ts
View file
Open in desktop
Expand Up @@ -39,7 +39,16 @@ interface Foo {
[key: string]: Foo;
}
`,

`
interface Foo<T> {
[key: string]: Foo<T>;
}
`,
`
interface Foo<T> {
[key: string]: Foo<T> | string;
}
`,
// Type literal
'type Foo = {};',
`
Expand Down Expand Up @@ -328,6 +337,17 @@ type Foo<A, B> = Readonly<Record<A, B>>;
},
{
code: `
interface Foo<T> {
[k: string]: T;
}
`,
output: `
type Foo<T> = Record<string, T>;
`,
errors: [{ messageId: 'preferRecord', line: 2, column: 1 }],
},
{
code: `
interface Foo {
[k: string]: A.Foo;
}
Expand Down