Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): Check 'rest' parameters in no-misused-promises #5731

Merged
merged 6 commits into from Oct 7, 2022
Merged

feat(eslint-plugin): Check 'rest' parameters in no-misused-promises #5731

merged 6 commits into from Oct 7, 2022

Commits on Oct 3, 2022

  1. feat(eslint-plugin): Check 'rest' parameters in no-misused-promises 

    Fixes typescript-eslint#4015

This extends 'no-misued-promises' with support for checking
variadic arguments passed to a 'rest' parameter. If a function
is declared with an argument like '...handlers: Array<() => void>',
we now check if the type argument to `Array` is a void-returning function,
and if so, check if any of the variadic arguments return a Promise.
    @Aaron1011
    Aaron1011 authored and Aaron Hill committed Oct 3, 2022
    Copy the full SHA
    0bb293b View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Address review comments

    @Aaron1011
    Aaron1011 committed Oct 4, 2022
    Copy the full SHA
    aac48e9 View commit details
    Browse the repository at this point in the history

  2. Fix spelling

    @Aaron1011
    Aaron1011 committed Oct 4, 2022
    Copy the full SHA
    5f91551 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Address additional review comments

    @Aaron1011
    Aaron1011 committed Oct 5, 2022
    Copy the full SHA
    0f01987 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. nit: split up tests a bit, and add comments about ()

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Oct 6, 2022
    Copy the full SHA
    3a3bb21 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Merge branch 'main' into misused-promise-rest

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Oct 7, 2022
    Copy the full SHA
    1342a7e View commit details
    Browse the repository at this point in the history