New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [no-use-before-define] add "allowNamedExports" option #5397
feat(eslint-plugin): [no-use-before-define] add "allowNamedExports" option #5397
Conversation
Thanks for the PR, @JesuisTong! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #5397 +/- ##
==========================================
+ Coverage 91.36% 93.82% +2.46%
==========================================
Files 132 290 +158
Lines 1494 9981 +8487
Branches 226 3004 +2778
==========================================
+ Hits 1365 9365 +8000
- Misses 65 335 +270
- Partials 64 281 +217
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I tried playing around with isForbidden
to keep from adding the new if (!options.allowNamedExports ...
block but couldn't find any logic to do so. Ah well.
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.31.0` -> `5.32.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.31.0/5.32.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.31.0` -> `5.32.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.31.0/5.32.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.32.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5320-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5310v5320-2022-08-01) [Compare Source](typescript-eslint/typescript-eslint@v5.31.0...v5.32.0) ##### Features - **eslint-plugin:** \[no-use-before-define] add "allowNamedExports" option ([#​5397](typescript-eslint/typescript-eslint#5397)) ([ad412cd](typescript-eslint/typescript-eslint@ad412cd)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.32.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5320-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5310v5320-2022-08-01) [Compare Source](typescript-eslint/typescript-eslint@v5.31.0...v5.32.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE0My4xIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1486 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
PR Checklist
Overview
Fixes #5324
[no-use-before-define] Add
allowNamedExports
option to adaptereslint@8.17.0