Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [consistent-type-imports] support fixing to inline types #5050

Merged
merged 31 commits into from Nov 7, 2022
Merged

feat(eslint-plugin): [consistent-type-imports] support fixing to inline types #5050

merged 31 commits into from Nov 7, 2022

Commits on Nov 7, 2022

  1. feat(eslint-plugin): [consistent-type-imports] support fixing to inli… 

    …ne types
    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    fb41191 View commit details
    Browse the repository at this point in the history

  2. first pass fix to simpler fixer

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    f78de8c View commit details
    Browse the repository at this point in the history

  3. cleanup pass 2

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    4bfcabf View commit details
    Browse the repository at this point in the history

  4. add test for default import

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    0cbcc64 View commit details
    Browse the repository at this point in the history

  5. add some docs

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    2ed8a09 View commit details
    Browse the repository at this point in the history

  6. add moar test cases

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    19dbb49 View commit details
    Browse the repository at this point in the history

  7. add failing test

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    6751315 View commit details
    Browse the repository at this point in the history

  8. use aImportIsOnlyTypes instead of inlineTypes message

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    be1930a View commit details
    Browse the repository at this point in the history

  9. wip

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    2b727f8 View commit details
    Browse the repository at this point in the history

  10. fix for default import inline

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    24df1da View commit details
    Browse the repository at this point in the history

  11. fix another case with as

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    14241ae View commit details
    Browse the repository at this point in the history

  12. simplify by using existing typeOverValue func

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    0925a7f View commit details
    Browse the repository at this point in the history

  13. add some commentse

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    71bbdf6 View commit details
    Browse the repository at this point in the history

  14. add another test for two imports from same source

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    6b2f1a7 View commit details
    Browse the repository at this point in the history

  15. better doc with link to 4.5

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    4f43a77 View commit details
    Browse the repository at this point in the history

  16. fix lint

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    043933e View commit details
    Browse the repository at this point in the history

  17. cleanup comments

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    a50cd23 View commit details
    Browse the repository at this point in the history

  18. Update packages/eslint-plugin/docs/rules/consistent-type-imports.md 

    Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
    @snewcomer @JoshuaKGoldberg
    snewcomer and JoshuaKGoldberg committed Nov 7, 2022
    Copy the full SHA
    cf703a0 View commit details
    Browse the repository at this point in the history

  19. Update packages/eslint-plugin/docs/rules/consistent-type-imports.md 

    Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
    @snewcomer @JoshuaKGoldberg
    snewcomer and JoshuaKGoldberg committed Nov 7, 2022
    Copy the full SHA
    6798d7e View commit details
    Browse the repository at this point in the history

  20. Update packages/eslint-plugin/docs/rules/consistent-type-imports.md 

    Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
    @snewcomer @JoshuaKGoldberg
    snewcomer and JoshuaKGoldberg committed Nov 7, 2022
    Copy the full SHA
    055db8d View commit details
    Browse the repository at this point in the history

  21. Update packages/eslint-plugin/src/rules/consistent-type-imports.ts 

    Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
    @snewcomer @JoshuaKGoldberg
    snewcomer and JoshuaKGoldberg committed Nov 7, 2022
    Copy the full SHA
    7104930 View commit details
    Browse the repository at this point in the history

  22. Update packages/eslint-plugin/src/rules/consistent-type-imports.ts 

    Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
    @snewcomer @JoshuaKGoldberg
    snewcomer and JoshuaKGoldberg committed Nov 7, 2022
    Copy the full SHA
    696ddb5 View commit details
    Browse the repository at this point in the history

  23. fix changelog formatting

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    821add2 View commit details
    Browse the repository at this point in the history

  24. Update packages/eslint-plugin/docs/rules/consistent-type-imports.md 

    Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
    @snewcomer @JoshuaKGoldberg
    snewcomer and JoshuaKGoldberg committed Nov 7, 2022
    Copy the full SHA
    849c2eb View commit details
    Browse the repository at this point in the history

  25. try single quotest

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    77298af View commit details
    Browse the repository at this point in the history

  26. cleanup not valid comment anymore

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    2b18686 View commit details
    Browse the repository at this point in the history

  27. Update packages/eslint-plugin/tests/rules/consistent-type-imports.tes… 

    …t.ts

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
    @snewcomer @JoshuaKGoldberg
    snewcomer and JoshuaKGoldberg committed Nov 7, 2022
    Copy the full SHA
    ec60d5b View commit details
    Browse the repository at this point in the history

  28. Update packages/eslint-plugin/tests/rules/consistent-type-imports.tes… 

    …t.ts

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
    @snewcomer @JoshuaKGoldberg
    snewcomer and JoshuaKGoldberg committed Nov 7, 2022
    Copy the full SHA
    83d095b View commit details
    Browse the repository at this point in the history

  29. rm comment

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    12dad78 View commit details
    Browse the repository at this point in the history

  30. improve documentation with feedback

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    5c26e08 View commit details
    Browse the repository at this point in the history

  31. add tabs

    @snewcomer
    snewcomer committed Nov 7, 2022
    Copy the full SHA
    f92cefd View commit details
    Browse the repository at this point in the history