Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ast-spec): add SpreadElement to ArrayExpression.elements #5025

Merged
merged 1 commit into from May 20, 2022
Merged

fix(ast-spec): add SpreadElement to ArrayExpression.elements #5025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/ast-spec/src/expression/ArrayExpression/spec.ts
View file
Open in desktop
@@ -1,8 +1,9 @@
import type { AST_NODE_TYPES } from '../../ast-node-types';
import type { BaseNode } from '../../base/BaseNode';
import type { SpreadElement } from '../../element/SpreadElement/spec';
import type { Expression } from '../../unions/Expression';

export interface ArrayExpression extends BaseNode {
type: AST_NODE_TYPES.ArrayExpression;
elements: Expression[];
elements: (Expression | SpreadElement)[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @bradzacher here because of the recent work with snapshots. But this LGTM in general!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct.
We won't require any one add snapshots for changes until the migration is finished.
There are still a few bits that might need some ironing out

}