Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): deprecate no-duplicate-imports in favour of import/no-duplicates #4973

Merged
merged 3 commits into from May 16, 2022
Merged

feat(eslint-plugin): deprecate no-duplicate-imports in favour of import/no-duplicates #4973

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7116ffc
chore: deprecate no-duplicate-imports
snewcomer May 14, 2022
a34f1d7
add replacedBy to meta
bradzacher May 16, 2022
7824785
Merge branch 'main' into deprecate-no-duplicate-imports
bradzacher May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/eslint-plugin/README.md
View file
Open in desktop
Expand Up @@ -209,7 +209,6 @@ In these cases, we create what we call an extension rule; a rule within our plug
| [`@typescript-eslint/lines-between-class-members`](./docs/rules/lines-between-class-members.md) | Require or disallow an empty line between class members | | :wrench: | |
| [`@typescript-eslint/no-array-constructor`](./docs/rules/no-array-constructor.md) | Disallow generic `Array` constructors | :white_check_mark: | :wrench: | |
| [`@typescript-eslint/no-dupe-class-members`](./docs/rules/no-dupe-class-members.md) | Disallow duplicate class members | | | |
| [`@typescript-eslint/no-duplicate-imports`](./docs/rules/no-duplicate-imports.md) | Disallow duplicate imports | | | |
| [`@typescript-eslint/no-empty-function`](./docs/rules/no-empty-function.md) | Disallow empty functions | :white_check_mark: | | |
| [`@typescript-eslint/no-extra-parens`](./docs/rules/no-extra-parens.md) | Disallow unnecessary parentheses | | :wrench: | |
| [`@typescript-eslint/no-extra-semi`](./docs/rules/no-extra-semi.md) | Disallow unnecessary semicolons | :white_check_mark: | :wrench: | |
Expand Down
4 changes: 4 additions & 0 deletions packages/eslint-plugin/docs/rules/no-duplicate-imports.md
View file
Open in desktop
Expand Up @@ -2,6 +2,10 @@

Disallow duplicate imports.

## DEPRECATED

This rule has been deprecated in favour of the [`import/no-duplicates`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/docs/rules/no-duplicates.md) rule.

## Rule Details

This rule extends the base [`eslint/no-duplicate-imports`](https://eslint.org/docs/rules/no-duplicate-imports) rule.
Expand Down
2 changes: 2 additions & 0 deletions packages/eslint-plugin/docs/rules/no-implicit-any-catch.md
View file
Open in desktop
Expand Up @@ -8,6 +8,8 @@ By default, TypeScript will type a catch clause variable as `any`, so explicitly

The `noImplicitAny` flag in TypeScript does not cover this for backwards compatibility reasons, however you can use `useUnknownInCatchVariables` (part of `strict`) instead of this rule.

## DEPRECATED
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I noticed that this has been deprecated, but this seems like an unrelated rule to no-duplicate-imports

Is this intentional? If not, is there a different rule we should use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript-eslint/packages/eslint-plugin/src/rules/no-implicit-any-catch.ts

Line 17 in 186fcf7

deprecated: true,

It was added here

TS 4.4 now has a compiler flag for this. So it's now a rule we don't need! Because 4.4 is still in RC, we'll just deprecate it, and remove it in the next major.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, excellent! I definitely missed that. Thanks for the detail! :)


## Rule Details

This rule requires an explicit type to be declared on a catch clause variable.
Expand Down
1 change: 0 additions & 1 deletion packages/eslint-plugin/src/configs/all.ts
View file
Open in desktop
Expand Up @@ -53,7 +53,6 @@ export = {
'@typescript-eslint/no-dupe-class-members': 'error',
'@typescript-eslint/no-duplicate-enum-values': 'error',
'no-duplicate-imports': 'off',
'@typescript-eslint/no-duplicate-imports': 'error',
'@typescript-eslint/no-dynamic-delete': 'error',
'no-empty-function': 'off',
'@typescript-eslint/no-empty-function': 'error',
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-plugin/src/rules/no-duplicate-imports.ts
View file
Open in desktop
Expand Up @@ -10,6 +10,7 @@ type MessageIds = util.InferMessageIdsTypeFromRule<typeof baseRule>;
export default util.createRule<Options, MessageIds>({
name: 'no-duplicate-imports',
meta: {
deprecated: true,
type: 'problem',
docs: {
description: 'Disallow duplicate imports',
Expand Down