Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: correct execution of test and dev scripts on Windows machines #4926

Merged
merged 4 commits into from May 10, 2022

Conversation

armano2
Copy link
Member

@armano2 armano2 commented May 9, 2022

PR Checklist

Overview

On Windows machines, allow tests to be executed, and correct issues with prebuild script

@nx-cloud
Copy link

nx-cloud bot commented May 9, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 41a4536. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint

This comment was marked as resolved.

@netlify
Copy link

netlify bot commented May 9, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 41a4536
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/627a0da6d71e5c0008f6b6ad
😎 Deploy Preview https://deploy-preview-4926--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 requested a review from bradzacher May 9, 2022 01:38
@armano2 armano2 added tests anything to do with testing repo maintenance things to do with maintenance of the repo, and not with code/docs labels May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #4926 (41a4536) into main (7275977) will decrease coverage by 2.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4926      +/-   ##
==========================================
- Coverage   94.25%   91.78%   -2.48%     
==========================================
  Files         153      226      +73     
  Lines        8305    10626    +2321     
  Branches     2702     3289     +587     
==========================================
+ Hits         7828     9753    +1925     
- Misses        263      591     +328     
- Partials      214      282      +68     
Flag Coverage Δ
unittest 91.78% <ø> (-2.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...internal/src/rules/no-typescript-default-import.ts 100.00% <0.00%> (ø)
packages/utils/src/ast-utils/predicates.ts 95.55% <0.00%> (ø)
...utils/src/ast-utils/eslint-utils/PatternMatcher.ts 100.00% <0.00%> (ø)
packages/utils/src/ts-eslint/index.ts 11.11% <0.00%> (ø)
packages/type-utils/src/requiresQuoting.ts 0.00% <0.00%> (ø)
packages/typescript-estree/src/ast-converter.ts 100.00% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/Definition.ts 100.00% <0.00%> (ø)
packages/typescript-estree/src/ts-estree/index.ts 50.00% <0.00%> (ø)
packages/utils/src/ts-eslint-scope/ScopeManager.ts 100.00% <0.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts 89.79% <0.00%> (ø)
... and 63 more

@armano2
Copy link
Member Author

armano2 commented May 10, 2022

@bradzacher updated, after further investigation, glob/globby (most likely fast-glob) is no longer working correctly when path has mixed slash and backslash on windows machines, I fixed that by use of cwd and absolute param

@armano2 armano2 requested a review from bradzacher May 10, 2022 07:25
@bradzacher bradzacher merged commit 77e15a9 into main May 10, 2022
@bradzacher bradzacher deleted the test/executing-tests-on-windows-machines branch May 10, 2022 23:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs tests anything to do with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants