New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [no-unnecessary-type-constraint] change to suggestion fix, fix multiple trailing comma failures #4901
fix(eslint-plugin): [no-unnecessary-type-constraint] change to suggestion fix, fix multiple trailing comma failures #4901
Conversation
…ion fix, fix multiple trailing comma failures
Thanks for the PR, @Josh-Cena! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
packages/eslint-plugin/tests/rules/no-unnecessary-type-constraint.test.ts
Outdated
Show resolved
Hide resolved
return ( | ||
(node.parent as TSESTree.TSTypeParameterDeclaration).params.length === | ||
1 && | ||
source.getTokensAfter(node)[0].value !== ',' && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know a better way to get the presence of trailing comma...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(me neither!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far! Posted a suggestion about the whitespace shenanigans, and a request for a bit more testing. But the logic looks good!
packages/eslint-plugin/tests/rules/no-unnecessary-type-constraint.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks! ✨
I'm not sure why the docs test is erroring. I've already removed the fixable icon. |
there are two rules lists that need to be updated. |
Head branch was pushed to by a user without write access
Codecov Report
@@ Coverage Diff @@
## main #4901 +/- ##
==========================================
+ Coverage 91.76% 94.25% +2.49%
==========================================
Files 226 153 -73
Lines 10586 8305 -2281
Branches 3280 2702 -578
==========================================
- Hits 9714 7828 -1886
+ Misses 591 263 -328
+ Partials 281 214 -67
Flags with carried forward coverage won't be shown. Click here to find out more. |
thanks for this! |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.22.0` -> `5.23.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.22.0/5.23.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.22.0` -> `5.23.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.22.0/5.23.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.23.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5230-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5220v5230-2022-05-09) [Compare Source](typescript-eslint/typescript-eslint@v5.22.0...v5.23.0) ##### Bug Fixes - **eslint-plugin:** \[no-restricted-imports] allow type import as long as there's one matching pattern ([#​4898](typescript-eslint/typescript-eslint#4898)) ([0419d28](typescript-eslint/typescript-eslint@0419d28)) - **eslint-plugin:** \[no-unnecessary-type-constraint] change to suggestion fix, fix multiple trailing comma failures ([#​4901](typescript-eslint/typescript-eslint#4901)) ([4507ac8](typescript-eslint/typescript-eslint@4507ac8)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.23.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5230-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5220v5230-2022-05-09) [Compare Source](typescript-eslint/typescript-eslint@v5.22.0...v5.23.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1345 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
PR Checklist
Overview
{}
being the actual constraint)