feat(typescript-estree): typeof private identifiers
#4832
Conversation
…pes[TSTypeParameterInstantiation]`
☁️ Nx Cloud ReportCI is running/has finished running commands for commit af7b0f3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
|
Thanks for the PR, @sosukesuzuki! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
❌ Deploy Preview for typescript-eslint failed.
|
| import type { EntityName } from '../../unions/EntityName'; | ||
|
|
||
| export interface TSQualifiedName extends BaseNode { | ||
| type: AST_NODE_TYPES.TSQualifiedName; | ||
| left: EntityName; | ||
| right: Identifier; | ||
| right: Identifier | PrivateIdentifier; |
There was a problem hiding this comment.
NGL - I do hate this a little bit because the only place that this.#foo is valid is in a typeof. It just means that consumers will have to check the type of this even though they'll know it's not possible.
It's probably not worth going to the effort of creating a separate AST node just for private member expressions within a type query.
|
They are pulling this feature from 4.7, so we can close this for now. |
PR Checklist
Overview
Based on #4829
Adds tests for
typeof this.#foo