New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [no-unused-vars] add destructuredArrayIgnorePattern options #4748
feat(eslint-plugin): [no-unused-vars] add destructuredArrayIgnorePattern options #4748
Conversation
Thanks for the PR, @ALOHACREPES345! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #4748 +/- ##
==========================================
+ Coverage 92.06% 94.33% +2.26%
==========================================
Files 355 151 -204
Lines 12097 8167 -3930
Branches 3455 2653 -802
==========================================
- Hits 11137 7704 -3433
+ Misses 630 258 -372
+ Partials 330 205 -125
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks @ALOHACREPES345! 🎉
Looks like codecov is having an unhappy moment. I'll apply the suggested fix to get a new commit, maybe that'll shake it into fixing itself. |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.16.0` -> `5.17.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.16.0/5.17.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.16.0` -> `5.17.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.16.0/5.17.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.17.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5170-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5160v5170-2022-03-28) [Compare Source](typescript-eslint/typescript-eslint@v5.16.0...v5.17.0) ##### Features - **eslint-plugin:** \[no-unused-vars] add destructuredArrayIgnorePattern options ([#​4748](typescript-eslint/typescript-eslint#4748)) ([6f8db8b](typescript-eslint/typescript-eslint@6f8db8b)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.17.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5170-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5160v5170-2022-03-28) [Compare Source](typescript-eslint/typescript-eslint@v5.16.0...v5.17.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1264 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
PR Checklist
Overview
implmented
destructuredArrayIgnorePattern
options just like base rule added. (eslint/eslint#15649)Also applied this fix(eslint/eslint@c4d8b0d).
This fix is needed for the new test case using
destructuredArrayIgnorePattern
andignoreRestSiblings
options. This test case is from base rule.It causes error without this fix.