Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [sort-type-union-intersection-members] Wrap the constructorType in parentheses #4590

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -85,7 +85,10 @@ function getGroup(node: TSESTree.TypeNode): Group {
}

function requiresParentheses(node: TSESTree.TypeNode): boolean {
return node.type === AST_NODE_TYPES.TSFunctionType;
return (
node.type === AST_NODE_TYPES.TSFunctionType ||
node.type === AST_NODE_TYPES.TSConstructorType
);
}

export type Options = [
Expand Down
Expand Up @@ -272,6 +272,15 @@ type T =
},
],
},
{
code: `type Expected = (new (x: number) => boolean) ${operator} string;`,
output: `type Expected = string ${operator} (new (x: number) => boolean);`,
errors: [
{
messageId: 'notSortedNamed',
},
],
},
];
};

Expand Down